Fix codesniffer issues

Author: tvdijen

src/Controller/LoginController.php

@@ -40,7 +40,7 @@ class LoginController
 
 
     /** @var string[] */
-    private const DEBUG_MODES = ['true', 'samlValidate'];
+    private const array DEBUG_MODES = ['true', 'samlValidate'];
 
 
     /** @var \SimpleSAML\Logger */

src/Controller/LogoutController.php

@@ -44,6 +44,7 @@ class LogoutController
 
     /** @var \SimpleSAML\Module\casserver\Cas\Ticket\TicketStore */
     protected TicketStore $ticketStore;
+
     private ServiceValidator $serviceValidator;
 
 

src/Shib13/AuthnResponse.php

@@ -28,11 +28,9 @@
  */
 class AuthnResponse
 {
-    /** @var string */
-    public const SHIB_PROTOCOL_NS = 'urn:oasis:names:tc:SAML:1.0:protocol';
+    public const string SHIB_PROTOCOL_NS = 'urn:oasis:names:tc:SAML:1.0:protocol';
 
-    /** @var string */
-    public const SHIB_ASSERT_NS = 'urn:oasis:names:tc:SAML:1.0:assertion';
+    public const string SHIB_ASSERT_NS = 'urn:oasis:names:tc:SAML:1.0:assertion';
 
 
     /**

tests/src/Controller/LogoutControllerTest.php

@@ -10,6 +10,7 @@
 use RuntimeException;
 use SimpleSAML\Auth\Simple;
 use SimpleSAML\Configuration;
+use SimpleSAML\HTTP\RunnableResponse;
 use SimpleSAML\Module;
 use SimpleSAML\Module\casserver\Controller\LogoutController;
 use SimpleSAML\Session;
@@ -281,9 +282,11 @@ public function testTicketIdGetsDeletedOnLogout(): void
 
     /**
      * Validates common things in the logout response
-     * @param Response $response The response from logout
+     *
+     * @param \Symfony\Component\HttpFoundation\Response $response The response from logout
      * @param string|null $redirectUrl The intended redirect url
      * @param bool $isShowPage If a logout page should be shown with a link to the url
+     *
      * @return void
      */
     public function validateLogoutResponse(