Skip to content

Disable allow power down when creating MCPWM timer #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025

Conversation

adamgerhant
Copy link

@adamgerhant adamgerhant commented Jun 17, 2025

The ESP driver code returns an error if the chip does not support retention of registers during power down when creating a MCPWM timer.

Driver code:

#if !SOC_MCPWM_SUPPORT_SLEEP_RETENTION
    ESP_RETURN_ON_FALSE(config->flags.allow_pd == 0, ESP_ERR_NOT_SUPPORTED, TAG, "register back up is not supported");

Also adds MT6701 to magnetic sensor i2c export

@runger1101001 runger1101001 self-assigned this Jun 17, 2025
@runger1101001 runger1101001 added the bug Something isn't working label Jun 17, 2025
@runger1101001 runger1101001 changed the base branch from master to dev June 17, 2025 10:17
@runger1101001 runger1101001 added this to the 2.3.5_Release milestone Jun 17, 2025
@runger1101001
Copy link
Member

Thank you very much for contributing this!

We only accept PRs to the dev branch, so I changed the base of your PR.

The ESP32-C3 test is failing, but I think its nothing to do with your PR.
The declaration of the MT6701 SPI settings was in fact already present on the dev branch. I've resolved the conflict in the PR.

I will merge the fix for the register retention. Thanks a lot for finding this!

@runger1101001 runger1101001 merged commit e235d70 into simplefoc:dev Jun 17, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants