-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 7.1 update => test coverage drop #1074
Comments
I'm also having trouble getting Simplecov to work with my "out of the box" rails minitest test suite (only have model tests and integration tests). I followed the install instructions and made the suggested changes to both the @lafeber One thing I've done to produce different results is comment out this line in my
I don't think this is the fix but see what it does for you... |
Have a look at #718 |
I'm running into this as well. @colszowka Can you take a look at this please? |
I'm having the same issue with Rspec instead of Minitest. Only on our Rails 7.1 branch |
We're getting similar results, specifically with controllers. Other files are being covered correctly. Confirmed that simplecov is being initialized before controllers run. Running Rails 7.1 + minitest. EDIT: My issue was Rails test parallelization. Fix here: #718 (comment) |
I've managed to "fix" it following this issue: #1082 |
Issue occurs when bumping rails from 7.0.8 to 7.1.0. No other changes in code.
We run minitest, with Rails 7.1 the line coverage of some files (mostly concerns) dropped from 100% to 0%.
before:
![image](https://private-user-images.githubusercontent.com/37751/274891854-3f394fa0-fd99-428d-9684-89cf26a20976.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1OTM4ODMsIm5iZiI6MTcyNTU5MzU4MywicGF0aCI6Ii8zNzc1MS8yNzQ4OTE4NTQtM2YzOTRmYTAtZmQ5OS00MjhkLTk2ODQtODljZjI2YTIwOTc2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDAzMzMwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTliNmY5MzU3MGUyNGJkMzc0YzIzYTgzMTg2ODc3ZGQzZTNmZGNhY2M3YmU4YTJjZDQxMGZlNjI3ZTQwZGM1NzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.r5DgPIAYnfY6U3l_KQpc-IKw0hTWEU_Tq81DWK4eowQ)
after:
![image](https://private-user-images.githubusercontent.com/37751/274891785-66c6ab42-19c2-4f5b-a3c8-e76ee212b32a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1OTM4ODMsIm5iZiI6MTcyNTU5MzU4MywicGF0aCI6Ii8zNzc1MS8yNzQ4OTE3ODUtNjZjNmFiNDItMTljMi00ZjViLWEzYzgtZTc2ZWUyMTJiMzJhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDAzMzMwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdjNDAyYThjOWMyOTM5NzlhMTY0NDQ4N2EzOWM2ODU1YjlkNWM5MzViYmViMmQ2MWJkMjNkYzQ5Y2JjNGFlZmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.5wCCs26E_IMXxPLdQrzEyTbARrQpjBUWY9D19AHX1Ao)
I don't know how much code I'm allowed to share; it's code that's called indirectly in the tests.
simplecov is at 0.22.0
ruby 3.1.4p223 (2023-03-30 revision 957bb7cb81) [x86_64-darwin21]
Edit: this is without parallelisation.
The text was updated successfully, but these errors were encountered: