Skip to content

Commit 9098a71

Browse files
committed
Only require what is needed from cgi
In ruby 3.5 most of the functionality will require adding cgi as a dependency. Only escape/unescape functions will remain, which is all that's needed here. So just use that functionality from `erb`. https://bugs.ruby-lang.org/issues/21258.
1 parent fec1a47 commit 9098a71

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

lib/simplecov-html.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# frozen_string_literal: true
22

33
require "erb"
4-
require "cgi"
54
require "fileutils"
65
require "digest/sha1"
76
require "time"

views/source_file.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
<% end %>
4949
<% end %>
5050

51-
<code class="ruby"><%= CGI.escapeHTML(line.src.chomp) %></code>
51+
<code class="ruby"><%= ERB::Util.html_escape(line.src.chomp) %></code>
5252
</li>
5353
</div>
5454
<% end %>

0 commit comments

Comments
 (0)