Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate PDFs on client side #282

Closed
1 of 4 tasks
mondeja opened this issue Apr 5, 2023 · 0 comments · Fixed by #290
Closed
1 of 4 tasks

Generate PDFs on client side #282

mondeja opened this issue Apr 5, 2023 · 0 comments · Fixed by #290
Labels
enhancement New feature or request

Comments

@mondeja
Copy link
Member

mondeja commented Apr 5, 2023

Kind of issue

  • Feature
  • Bug
  • Design
  • Other, namely:

Description

We can use PDFKit and blob-stream (maybe this not necessary) to generate icon PDFs versions on the fly. This would maybe deprecate the simple-icons-pdf repository which is not maintained. Anyways it would allow us to remove the postinstall repository download from master branch which is really weird.

I've implemented this at simple-icons-website-rs, see this file for the implementation (generate PDF from icon slug using the SVG file) and the function for lazy loading the libraries which are attached as scripts only when a) the user selects the PDF download type through control or b) when the PDF download type is loaded from local storage.

@mondeja mondeja added the enhancement New feature or request label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant