From 9518190e92b510d548559a7433179db92f656dcf Mon Sep 17 00:00:00 2001 From: Evan Stade Date: Wed, 3 May 2023 11:33:25 -0700 Subject: [PATCH] Reland "Storage buckets: make Bucket File System aware of quota limit" This reverts commit 5d667161bd35c3ead343b9b4b38ed5edf9818231. Reason for revert: build fixed in ps2 Original change's description: > Revert "Storage buckets: make Bucket File System aware of quota limit" > > This reverts commit 478714b5b29230c1974a4b2378b2f7582fd11dd6. > > Reason for revert: > LUCI Bisection identified this CL as the culprit of a build failure. See the analysis: https://luci-bisection.appspot.com/analysis/b/8782164710170685953 > > Sample failed build: https://ci.chromium.org/b/8782164710170685953 > > If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fluci-bisection.appspot.com%2Fanalysis%2Fb%2F8782164710170685953&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F4494605 > > Original change's description: > > Storage buckets: make Bucket File System aware of quota limit > > > > Bug: 1315396 > > Change-Id: I830fa2f0d4841458d48dffb053850d704cbbbe9d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4494605 > > Reviewed-by: Austin Sullivan > > Commit-Queue: Evan Stade > > Cr-Commit-Position: refs/heads/main@{#1138703} > > > > Bug: 1315396 > Change-Id: Iaa3174bf065758c0baeab849fe86d3c27baaea79 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4501071 > Owners-Override: luci-bisection@appspot.gserviceaccount.com > Commit-Queue: luci-bisection@appspot.gserviceaccount.com > Bot-Commit: luci-bisection@appspot.gserviceaccount.com > Cr-Commit-Position: refs/heads/main@{#1138718} Bug: 1315396 Change-Id: Iccf00ca00750f17bd6d1c870da4b257c6f1dac7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4500652 Commit-Queue: Austin Sullivan Auto-Submit: Evan Stade Reviewed-by: Austin Sullivan Cr-Commit-Position: refs/heads/main@{#1139024} --- .../FileSystemBaseHandle-buckets.js | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/fs/script-tests/FileSystemBaseHandle-buckets.js b/fs/script-tests/FileSystemBaseHandle-buckets.js index 01c41231808e2c..c06e940d7e9c5a 100644 --- a/fs/script-tests/FileSystemBaseHandle-buckets.js +++ b/fs/script-tests/FileSystemBaseHandle-buckets.js @@ -21,3 +21,22 @@ directory_test(async (t, root_dir) => { const directoryPromise = inboxBucket.getDirectory(); await promise_rejects_dom(t, 'InvalidStateError', directoryPromise); }, 'getDirectory promise rejects if bucket has been deleted'); + +directory_test(async (t, root_dir) => { + await prepareForBucketTest(t); + + const inboxBucket = await navigator.storageBuckets.open('inbox', {quota: 500}); + const inboxRootDir = await inboxBucket.getDirectory(); + + // Short file succeeds. + const file = + await createFileWithContents(t, 'mtime.txt', 'short file', inboxRootDir); + + // Longer file fails. + return promise_rejects_dom( + t, 'QuotaExceededError', + createFileWithContents( + t, 'mtime2.txt', + 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum', + inboxRootDir)); +}, 'Bucket quota restricts the size of a file that can be created');