Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visual effect to Pressable #67

Closed
simonwacker opened this issue Nov 4, 2021 · 0 comments · Fixed by #69
Closed

Add visual effect to Pressable #67

simonwacker opened this issue Nov 4, 2021 · 0 comments · Fixed by #69
Assignees
@simonwacker

Comments

@simonwacker
Copy link
Owner

simonwacker commented Nov 4, 2021 •
edited
Loading

On Android this can simply be done with android_ripple. Let's hope that a similar option becomes available for iOS.

For some Pressables, this was done in f94b884 The ripple effect does not work for buttons though despite f94b884#diff-a89bd1e62fbee0d87c094d4b71d37821d64fa7cc0e946cee1689baa1f199c5cbR39 because the buttons has a background color hiding the ripple effect. In newer versions of react native RippleConfig has a property foreground that we should set to true for buttons. The pull request facebook/react-native#30466 seems to be related to the foreground property.

Shall we also add ripple effects to Pressable icons like play, pause, and so forth in the audio player?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonwacker simonwacker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use react native paper user interface components simonwacker/yoga-insights
1 participant
@simonwacker