-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more STRICT table support #604
Conversation
Make table.transform() preserve STRICT mode.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
==========================================
- Coverage 95.77% 95.72% -0.06%
==========================================
Files 8 8
Lines 2842 2852 +10
==========================================
+ Hits 2722 2730 +8
- Misses 120 122 +2 ☔ View full report in Codecov by Sentry. |
This looks really great on first glance - design is good, implementation is solid, tests and documentation look great. Looks like a couple of
|
Apologies - I pushed a fix that addresses the mypy failures. |
Also tested this manually like so: sqlite-utils create-table strict.db strictint id integer size integer --strict
sqlite-utils create-table strict.db notstrictint id integer size integer
sqlite-utils install sqlite-utils-shell
sqlite-utils shell strict.db
|
Make
table.transform()
preserve STRICT mode.📚 Documentation preview 📚: https://sqlite-utils--604.org.readthedocs.build/en/604/