Skip to content

Conversation

@simonw
Copy link
Owner

@simonw simonw commented Nov 27, 2025

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 94.18283% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.08%. Comparing base (68f1179) to head (a61a3ef).

Files with missing lines Patch % Lines
datasette/default_permissions/config.py 89.51% 15 Missing ⚠️
datasette/default_permissions/tokens.py 90.74% 5 Missing ⚠️
datasette/default_permissions/restrictions.py 98.86% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2603      +/-   ##
==========================================
+ Coverage   89.99%   90.08%   +0.08%     
==========================================
  Files          45       51       +6     
  Lines        7398     7493      +95     
==========================================
+ Hits         6658     6750      +92     
- Misses        740      743       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Remove dead code: is_resource_allowed() method was never called
- Change isinstance check to assertion with error message
- Add test cases for table-level restrictions in restrictions_allow_action()
- Coverage for restrictions.py improved from 79% to 99%

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants