Confirm if documented nginx proxy config works for row pages with escaped characters in their primary key

[simonw]

Found this while working on https://github.com/simonw/datasette-tiddlywiki

Then clicking on /tiddlywiki/tiddlers/%24%3A%2FDefaultTiddlers returns a 404.

[simonw]

This problem doesn't occur on my localhost running Uvicorn directly - but I'm seeing it in my production environment that runs Datasette behind an nginx proxy:

    location / {
        proxy_pass http://127.0.0.1:8000/;
	proxy_set_header Host $host;
    }

[simonw]

This StackOverflow answer suggests that the fix is to change this:

proxy_pass http://127.0.0.1:8000/;

To this:

proxy_pass http://127.0.0.1:8000;

Quoting the nginx documentation: http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_pass

A request URI is passed to the server as follows:

• If the proxy_pass directive is specified with a URI, then when a request is passed to the server, the part of a normalized request URI matching the location is replaced by a URI specified in the directive:

  location /name/ {
      proxy_pass http://127.0.0.1/remote/;
  }
  

• If proxy_pass is specified without a URI, the request URI is passed to the server in the same form as sent by a client when the original request is processed, or the full normalized request URI is passed when processing the changed URI:

  location /some/path/ {
      proxy_pass http://127.0.0.1;
  }
  

[simonw]

Confirmed, that fixed the bug for me on my server.

[simonw]

The example nginx config on https://docs.datasette.io/en/stable/deploying.html#nginx-proxy-configuration is currently:

daemon off;

events {
  worker_connections  1024;
}
http {
  server {
    listen 80;
    location /my-datasette {
      proxy_pass http://127.0.0.1:8009/my-datasette;
      proxy_set_header Host $host;
    }
  }
}

This looks to me like it might exhibit the bug. Need to confirm that and figure out an alternative.