Possible bug reacquiring lock in 372 agent

[jlashner]

I was just looking through the 372 agent usage of release_and_acquire and I'm confused by this behavior:

socs/agents/lakeshore372/LS372_agent.py

Lines 202 to 205 in 4c8224e

	if not self._lock.release_and_acquire(timeout=10):
	self.log.warn(f"Failed to re-acquire sampling lock, "
	f"currently held by {self._lock.job}.")
	continue

This continue seems a bit sketchy as on the next iteration of the loop it'll try to release_and_acquire a second time, but having never actually re-acquired the lock...

[mhasself]

Agreed. Not sure what the right fix is. Probably needs to return xxx rather than continue. One could imagine trying to reacquire again, later... but really this shouldn't be happening so failing out is probably advisable.

[jlashner]

I agree, maybe return False with that warning message instead of logging it?

[sanahabhimani]

Was this fixed in the agent?