Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev update install instructions #127

Merged
merged 24 commits into from
May 31, 2023
Merged

Conversation

mgerbino
Copy link
Collaborator

This PR updates install instructions including guidance on how to solve installation issues of cosmopower/tensorflow on M1 Mac. Fixes #109

Still to be checked: install instructions at NERSC (beyond CORI)

@mgerbino mgerbino requested a review from itrharrison May 15, 2023 15:15
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #127 (49e4263) into master (2068146) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   73.12%   73.12%           
=======================================
  Files          30       30           
  Lines        1935     1935           
=======================================
  Hits         1415     1415           
  Misses        520      520           
Impacted Files Coverage Δ
soliket/ccl.py 93.22% <ø> (ø)

@itrharrison itrharrison added this to the v0.1 milestone May 26, 2023
@itrharrison
Copy link
Collaborator

@HTJense is the installation of the conda env necessary for readthedocs? It slows down the docs build quite a bit.

@HTJense
Copy link
Member

HTJense commented May 27, 2023

@HTJense is the installation of the conda env necessary for readthedocs? It slows down the docs build quite a bit.

I don't know, I doubt it, but you can try without it and see if it works better 🤷🏾‍♀️

@itrharrison itrharrison marked this pull request as ready for review May 30, 2023 09:39
@itrharrison itrharrison added the documentation Improvements or additions to documentation label May 30, 2023
reneehlozek
reneehlozek previously approved these changes May 30, 2023
Copy link
Collaborator

@reneehlozek reneehlozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general comments and suggested changes

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
docs/ccl.rst Outdated Show resolved Hide resolved
docs/developers.rst Show resolved Hide resolved
docs/developers.rst Outdated Show resolved Hide resolved
docs/developers.rst Outdated Show resolved Hide resolved
docs/documentation.rst Show resolved Hide resolved
docs/documentation.rst Outdated Show resolved Hide resolved
docs/workflow.rst Show resolved Hide resolved
Co-authored-by: reneehlozek <renee.hlozek@gmail.com>
itrharrison and others added 3 commits May 30, 2023 11:35
Co-authored-by: reneehlozek <renee.hlozek@gmail.com>
Co-authored-by: reneehlozek <renee.hlozek@gmail.com>
@itrharrison itrharrison requested review from reneehlozek and removed request for itrharrison May 30, 2023 11:14
Copy link
Collaborator

@reneehlozek reneehlozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍹

@itrharrison itrharrison merged commit 381675b into master May 31, 2023
@itrharrison itrharrison deleted the dev-update-install-instructions branch May 31, 2023 10:20
mgerbino added a commit that referenced this pull request Oct 4, 2023
* updated install instructions and readme

* updated install instructions

* updated install instructions

* updates to readme

* change image path for readme

* added logo

* create separeate text for readme and docs index

* removed old instructions from install.rst

* added developers page to consolidate guidance

* added docs guidelines page

* typos and move docs doc

* remove depracated files

* removed old guidelines, integrated into developers.rst

* changed dev guidleines name in readme

* add sphinxemoji

* remove emoji :-(

* remove env build from readthedocs

* readd env build from readthedocs as necessary

* added missing workflow docs page

* Update README.rst

Co-authored-by: reneehlozek <renee.hlozek@gmail.com>

* Update README.rst

Co-authored-by: reneehlozek <renee.hlozek@gmail.com>

* Update docs/developers.rst

Co-authored-by: reneehlozek <renee.hlozek@gmail.com>

* docs fixes after review

---------

Co-authored-by: Martina Gerbino <bradamante@martina.local>
Co-authored-by: Ian Harrison <itrharrison@gmail.com>
Co-authored-by: reneehlozek <renee.hlozek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install soliket on macos M1
5 participants