Skip to content

Commit 025c0d5

Browse files
committed
Apply suggestions from code review
Co-Authored-By: Andrew Gorcester <gorcester@google.comm> Apply suggestions from code review
1 parent 6bc19d7 commit 025c0d5

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
09-10-2019 13:43 PDT
1010

1111
### Deprecations
12-
- Deprecate `max_memcache_items`, memcache options, `force_rewrites`, `Query.map()`, `Query.mapi_async()`, `blobstore`. ([#168](https://github.com/googleapis/python-ndb/pull/168))
12+
- Deprecate `max_memcache_items`, memcache options, `force_rewrites`, `Query.map()`, `Query.map_async()`, `blobstore`. ([#168](https://github.com/googleapis/python-ndb/pull/168))
1313

1414
### Implementation Changes
1515
- Fix error retrieving values for properties with different stored name ([#187](https://github.com/googleapis/python-ndb/pull/187))
@@ -34,8 +34,8 @@
3434
- Implement ``Context.flush`` ([#158](https://github.com/googleapis/python-ndb/pull/158))
3535
- Implement ``use_datastore`` flag. ([#155](https://github.com/googleapis/python-ndb/pull/155))
3636
- Implement ``tasklets.toplevel``. ([#157](https://github.com/googleapis/python-ndb/pull/157))
37-
- RedisCache ([#150](https://github.com/googleapis/python-ndb/pull/150))
38-
- Implement Global Cache (memcache) ([#148](https://github.com/googleapis/python-ndb/pull/148))
37+
- Add RedisCache implementation of global cache ([#150](https://github.com/googleapis/python-ndb/pull/150))
38+
- Implement Global Cache ([#148](https://github.com/googleapis/python-ndb/pull/148))
3939
- ndb.Expando properties load and save ([#117](https://github.com/googleapis/python-ndb/pull/117))
4040
- Implement cache policy. ([#116](https://github.com/googleapis/python-ndb/pull/116))
4141

@@ -49,14 +49,13 @@
4949
- Add spellcheck sphinx extension to docs build process ([#123](https://github.com/googleapis/python-ndb/pull/123))
5050

5151
### Internal / Testing Changes
52-
- Clean up usage of object.__new__ and mocks for `Model` in unit tests ([#177](https://github.com/googleapis/python-ndb/pull/177))
52+
- Clean up usage of `object.__new__` and mocks for `Model` in unit tests ([#177](https://github.com/googleapis/python-ndb/pull/177))
5353
- Prove tasklets can be Python 2.7 and 3.7 compatible. ([#174](https://github.com/googleapis/python-ndb/pull/174))
5454
- Discard src directory and fix flake8 failures ([#173](https://github.com/googleapis/python-ndb/pull/173))
55-
- Some additional tests for `Model.__eq__()` ([#169](https://github.com/googleapis/python-ndb/pull/169))
55+
- Add tests for `Model.__eq__()` ([#169](https://github.com/googleapis/python-ndb/pull/169))
5656
- Remove skip flag accidentally left over ([#154](https://github.com/googleapis/python-ndb/pull/154))
5757
- Try to get kokoro to add indexes for system tests ([#145](https://github.com/googleapis/python-ndb/pull/145))
5858
- Add system test for PolyModel ([#133](https://github.com/googleapis/python-ndb/pull/133))
59-
- Ask for feature development coordination via issues
6059
- Fix system test under Datastore Emulator. (Fixes [#118](https://github.com/googleapis/python-ndb/pull/118)) ([#119](https://github.com/googleapis/python-ndb/pull/119))
6160
- Add unit tests for `_entity_from_ds_entity` expando support ([#120](https://github.com/googleapis/python-ndb/pull/120))
6261

0 commit comments

Comments
 (0)