Fix testing's pubspec, ensuring useResult is available in meta (dart-lang#2720)

Author: srawlins

lib/dartdoc.dart

@@ -128,7 +128,7 @@ class Dartdoc {
   Dartdoc._(this.config, this._generator, this.packageBuilder) {
     _outputDir = config.resourceProvider
         .getFolder(config.resourceProvider.pathContext.absolute(config.output))
-          ..create();
+      ..create();
   }
 
   // TODO(srawlins): Remove when https://github.com/dart-lang/linter/issues/2706

lib/src/generator/templates.runtime_renderers.dart

@@ -14894,6 +14894,7 @@ const _invisibleGetters = {
     'hasProtected',
     'hasRequired',
     'hasSealed',
+    'hasUseResult',
     'hasVisibleForTemplate',
     'hasVisibleForTesting',
     'id',
@@ -14934,6 +14935,7 @@ const _invisibleGetters = {
     'isRequired',
     'isSealed',
     'isTarget',
+    'isUseResult',
     'isVisibleForTemplate',
     'isVisibleForTesting'
   },
@@ -14962,6 +14964,7 @@ const _invisibleGetters = {
     'hasProtected',
     'hasRequired',
     'hasSealed',
+    'hasUseResult',
     'hasVisibleForTemplate',
     'hasVisibleForTesting',
     'id',
@@ -15179,6 +15182,7 @@ const _invisibleGetters = {
     'hasProtected',
     'hasRequired',
     'hasSealed',
+    'hasUseResult',
     'hasVisibleForTemplate',
     'hasVisibleForTesting',
     'id',
@@ -15318,6 +15322,7 @@ const _invisibleGetters = {
     'hasProtected',
     'hasRequired',
     'hasSealed',
+    'hasUseResult',
     'hasVisibleForTemplate',
     'hasVisibleForTesting',
     'id',

lib/src/model/categorization.dart

@@ -107,7 +107,7 @@ abstract class Categorization implements ModelElement {
         .map((n) => package.nameToCategory[n])
         .where((c) => c != null)
         .toList()
-          ..sort();
+      ..sort();
     return _categories;
   }
 

lib/src/model/documentation_comment.dart

@@ -635,7 +635,9 @@ mixin DocumentationComment
     for (var match in exp.allMatches(string)) {
       var prefix = match.input.substring(currentIndex, match.start);
       currentIndex = match.end;
-      replaced..write(prefix)..write(await replace(match));
+      replaced
+        ..write(prefix)
+        ..write(await replace(match));
     }
     replaced.write(string.substring(currentIndex));
     return replaced.toString();

lib/src/warnings.dart

@@ -62,7 +62,7 @@ Future<List<DartdocOption<Object>>> createPackageWarningOptions(
                     .where(
                         (d) => d.defaultWarningMode == PackageWarningMode.error)
                     .toList()
-                      ..sort())
+                  ..sort())
                 .map((d) => '   ${d.warningName}: ${d.shortHelp}')
                 .join('\n')),
     DartdocOptionArgFile<List<String>>('ignore', null, resourceProvider,
@@ -72,7 +72,7 @@ Future<List<DartdocOption<Object>>> createPackageWarningOptions(
                     .where((d) =>
                         d.defaultWarningMode == PackageWarningMode.ignore)
                     .toList()
-                      ..sort())
+                  ..sort())
                 .map((d) => '   ${d.warningName}: ${d.shortHelp}')
                 .join('\n')),
     DartdocOptionArgFile<List<String>>('warnings', null, resourceProvider,
@@ -83,7 +83,7 @@ Future<List<DartdocOption<Object>>> createPackageWarningOptions(
                         .where((d) =>
                             d.defaultWarningMode == PackageWarningMode.warn)
                         .toList()
-                          ..sort())
+                      ..sort())
                     .map((d) => '   ${d.warningName}: ${d.shortHelp}')
                     .join('\n')),
     // Synthetic option uses a factory to build a PackageWarningOptions from all the above flags.

test/dartdoc_options_test.dart

@@ -177,13 +177,13 @@ void main() {
     tempDir = resourceProvider.createSystemTemp('options_test');
     firstDir = resourceProvider
         .getFolder(resourceProvider.pathContext.join(tempDir.path, 'firstDir'))
-          ..create();
+      ..create();
     firstExisting = resourceProvider.getFile(
         resourceProvider.pathContext.join(firstDir.path, 'existing.dart'))
       ..writeAsStringSync('');
     secondDir = resourceProvider
         .getFolder(resourceProvider.pathContext.join(tempDir.path, 'secondDir'))
-          ..create();
+      ..create();
     resourceProvider
         .getFile(
             resourceProvider.pathContext.join(secondDir.path, 'existing.dart'))

testing/test_package/pubspec.yaml

@@ -3,7 +3,7 @@ homepage: http://github.com/dart-lang
 description: Best package ever.
 version: 0.0.1
 dependencies:
-  meta: ^1.0.0
+  meta: ^1.4.0
   args: ^1.5.0
   test_package_imported:
     path: "../test_package_imported"

tool/grind.dart

@@ -220,7 +220,7 @@ void updateThirdParty() async {
       .map((e) => path.basename(e.path))
       .where(_mustache4dartPatches.hasMatch)
       .toList()
-        ..sort()) {
+    ..sort()) {
     run('patch',
         arguments: [
           '-p0',