Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export query function #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

titanism
Copy link

@titanism titanism commented Mar 2, 2023

This exports the query function so that users can use custom resolver options, e.g. 🍊 Tangerine which supports DNS over HTTPS ("DoH").

This exports the `query` function so that users can use custom `resolver` options, e.g. 🍊 [Tangerine](https://github.com/forwardemail/tangerine) which supports DNS over HTTPS ("DoH").
@titanism
Copy link
Author

titanism commented Mar 2, 2023

It would be nice to be able to pass a custom resolver from the get-go. Also - the timeout stuff should be configurable or if you pass a custom resolver it should be disabled, because otherwise it'd cancel all dns requests because it calls .cancel() method. Maybe an AbortController is better - or leave it up to the user - and tell them this in the README.

@silverwind
Copy link
Owner

silverwind commented Mar 18, 2023

Hmm I think it's better to introduce a opts.resolver option on the public APIs lookup and batch. Exporting this "dirty" internal function seems wrong to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants