Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of ChangeSet from RecursivePublishable #472

Open
1 task
emteknetnz opened this issue Sep 5, 2024 · 0 comments
Open
1 task

Remove use of ChangeSet from RecursivePublishable #472

emteknetnz opened this issue Sep 5, 2024 · 0 comments

Comments

@emteknetnz
Copy link
Member

RecursivePublishable::publishRecursive() will create a ChangeSet + (child ChangeSetItem indirectly) whenever any object is published. This is at least partially responsible for the large ChangeSet/ChangeSetItem database tables that some websites have.

The ChangeSet functionality is used primarily for silverstripe/campaign-admin. It's believed that the ChangeSet were originally intended to be a more core part of Versioning and facilitate rollbacks, though that's not how rollbacks are implemented right now and it seems very unlikely we'd switch to using ChangeSets

It seems like we should simply remove the creation of a ChangeSet/ChangeSetItem in CMS 6 since the database records created are pretty much pointless

Acceptance criteria

  • Stop creating ChangeSet/ChangeSetItem records in RecursivePublishable::publishRecursive()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant