Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Versioned to use more composition #421

Open
maxime-rainville opened this issue Oct 20, 2023 · 0 comments
Open

Refactor Versioned to use more composition #421

maxime-rainville opened this issue Oct 20, 2023 · 0 comments

Comments

@maxime-rainville
Copy link
Contributor

maxime-rainville commented Oct 20, 2023

Story

As a development team, we want Versioned's logic to be composable and well structured to minimise our long term maintenance.

Context

Versioned has a lot of code that got tacked on over the years without an overarching view, e.g. RecursivePublishable was added on top of it because it didn't make the CMS 4 cut off.

The primary Versioned class is ridiculously big which makes it difficult to understand what it's trying to do.

Acceptance criteria

  • Versioned is refactored with an eye to making it composable with Services.
  • Common use case still work out of the box.
  • Potential pitfalls with more advanced use case are called out in the changelog.
  • Concerns related to GridField and UI management are moved to other module.
@maxime-rainville maxime-rainville added this to the Silverstripe CMS 6 milestone Oct 20, 2023
@michalkleiner michalkleiner changed the title Refactor versionned to use more composition Refactor Versioned to use more composition Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant