Dead (or broken?) code in VersionedGridFieldItemRequest

[kinglozzer]

silverstripe-versioned/src/VersionedGridFieldItemRequest.php

Lines 392 to 409 in a0a216c

	protected function addUnversionedButtons(DataObject $record, FieldList $actions)
	{
	if (!$record->canEdit()) {
	return;
	}
	$saveAction = $actions->fieldByName('action_doSave');
	if (!$saveAction) {
	return;
	}
	if (!$this->record->ID) {
	return;
	}
	$saveAction->setTitle(_t(
	__CLASS__ . '.BUTTONAPPLYCHANGES',
	'Apply changes'
	))->addExtraClass('btn-primary font-icon-save');
	}
	}

If an un-versioned object has $owns set, the above method is called. However, $saveAction is always null because the action is contained in a CompositeField, so it can’t be found like this.

The button should say “Apply changes” instead of “Save”, which I remember it used to but doesn’t anymore. I tried using the approach in addVersionedButtons() below, but this results in a broken button (invisible text, disappears when changes are made) any I don’t have time to debug that right now!

$majorActions = $actions->fieldByName('MajorActions');
$saveAction = ($majorActions) ? $majorActions->fieldByName('action_doSave') : null;

I’m not sure if we should just remove this, or “fix” it so the button says “Apply Changes” again?