From c1e66e809cae1bddc26970f5ec2a05eeaa705353 Mon Sep 17 00:00:00 2001 From: Sabina Talipova Date: Fri, 13 Oct 2023 12:44:44 +1300 Subject: [PATCH] MNT Remove TODO comments --- src/Forms/GridFieldExportReportButton.php | 1 - tests/php/UserSecurityReportTest.php | 1 - 2 files changed, 2 deletions(-) diff --git a/src/Forms/GridFieldExportReportButton.php b/src/Forms/GridFieldExportReportButton.php index c80ce09..5b2afa1 100644 --- a/src/Forms/GridFieldExportReportButton.php +++ b/src/Forms/GridFieldExportReportButton.php @@ -60,7 +60,6 @@ public function generateExportFileData($gridField) // The is the only variation from the parent, using getList() instead of getManipulatedList() $items = $gridField->getList(); - // @todo should GridFieldComponents change behaviour based on whether others are available in the config? foreach ($gridField->getConfig()->getComponents() as $component) { if ($component instanceof GridFieldFilterHeader || $component instanceof GridFieldSortableHeader) { $items = $component->getManipulatedData($gridField, $items); diff --git a/tests/php/UserSecurityReportTest.php b/tests/php/UserSecurityReportTest.php index fe6a67b..6cee0de 100644 --- a/tests/php/UserSecurityReportTest.php +++ b/tests/php/UserSecurityReportTest.php @@ -42,7 +42,6 @@ class UserSecurityReportTest extends SapphireTest * Utility method for all tests to use. * * @return ArrayList - * @todo pre-fill the report with fixture-defined users */ protected function setUp(): void {