Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS 6: Remove backwards compatibility casting null to empty string in ArrayList::filterOrExclude() #10930

Open
2 tasks
GuySartorelli opened this issue Aug 28, 2023 · 0 comments

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Aug 28, 2023

In #10925 a new ArrayList::filterOrExclude() method was implemented which uses some null coalescing operators to turn null values (both in the objects contained in the list and the values to be passed to the SearchFilter) to empty strings. This is being done to preserve backwards compatibility with the old == comparison that arraylist filtering used to do.

From CMS 6, that backwards compatibility is no longer needed. It would be more appropriate to use strict comparisons for null values, to match up with how DataList and EagerLoadedList treat null value comparisons.

Acceptance criteria

  • The null coalescing operators are removed from ArrayList::filterOrExclude() so that null values contained in the list and null values passed to the various filter methods are passed through to the searchfilters as null.
  • This change is called out in the changelog

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant