Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thirdparty jQuery libraries #1351

Closed
2 of 3 tasks
emteknetnz opened this issue Aug 28, 2022 · 3 comments
Closed
2 of 3 tasks

Update thirdparty jQuery libraries #1351

emteknetnz opened this issue Aug 28, 2022 · 3 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Aug 28, 2022

There are unmanaged jquery libraries in the thirdparty directories such as jquery-entwine.

ACs

  • jquery libraries in the thirdparty directories need to be updated to work with jQuery 3.6.0+
  • Behat on silverstripe/installer is green

Stretch goal

  • Migrate from thirdparty folder to be regular npm dependencies that get built with yarn build

Notes

  • This need to be targetted to the 4 branch and will be released in 4.12

Previous POC PRs - for reference only, start a new PR for the actual work

PRs

@GuySartorelli
Copy link
Member

I have spun off some of the jQuery library upgrades as separate cards since they can (and in some cases must) be done separately:

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 18, 2022

Note: While working on this I have also run into existing console errors that were caused by the following issues

@emteknetnz
Copy link
Member Author

Linked PRs have been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants