This repository was archived by the owner on May 20, 2025. It is now read-only.
Support blocking queries to /health #3
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a very modest proposal for enhancement, to make it possible to use blocking queries with
consul.health.*
endpoints... It's backwards compatible...To use blocking queries, you must provide the
?index= param
which you obtained in the response headers of the previous call.health
HTTP responses do not include aModifyIndex
field like thekv
ones. Instead, you must use theX-Consul-Index
HTTP header... But inconsul.health
, only theres.body
is returned.This modification adds an optional
headers
parameter to the callback so the caller can get theX-Consul-Index
or other consul specific headers (do we have a leader ? time of last contact) as per the consul.io docs...If the caller implements a classic 2 params callback, the headers are silently discarded.
If he implements the 3 params callback, he'll receive the headers.
What do you think ?
Example headers: