Skip to content

Commit 43c8518

Browse files
committed
(refs gitbucket#1610)Redirect if the issue is a pull request
1 parent 1b65ae2 commit 43c8518

File tree

1 file changed

+16
-12
lines changed

1 file changed

+16
-12
lines changed

src/main/scala/gitbucket/core/controller/IssuesController.scala

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -76,25 +76,29 @@ trait IssuesControllerBase extends ControllerBase {
7676
get("/:owner/:repository/issues")(referrersOnly { repository =>
7777
val q = request.getParameter("q")
7878
if(Option(q).exists(_.contains("is:pr"))){
79-
redirect(s"/${repository.owner}/${repository.name}/pulls?q=" + StringUtil.urlEncode(q))
79+
redirect(s"/${repository.owner}/${repository.name}/pulls?q=${StringUtil.urlEncode(q)}")
8080
} else {
8181
searchIssues(repository)
8282
}
8383
})
8484

8585
get("/:owner/:repository/issues/:id")(referrersOnly { repository =>
8686
defining(repository.owner, repository.name, params("id")){ case (owner, name, issueId) =>
87-
getIssue(owner, name, issueId) map {
88-
html.issue(
89-
_,
90-
getComments(owner, name, issueId.toInt),
91-
getIssueLabels(owner, name, issueId.toInt),
92-
getAssignableUserNames(owner, name),
93-
getMilestonesWithIssueCount(owner, name),
94-
getLabels(owner, name),
95-
isIssueEditable(repository),
96-
isIssueManageable(repository),
97-
repository)
87+
getIssue(owner, name, issueId) map { issue =>
88+
if(issue.isPullRequest){
89+
redirect(s"/${repository.owner}/${repository.name}/pull/${issueId}")
90+
} else {
91+
html.issue(
92+
issue,
93+
getComments(owner, name, issueId.toInt),
94+
getIssueLabels(owner, name, issueId.toInt),
95+
getAssignableUserNames(owner, name),
96+
getMilestonesWithIssueCount(owner, name),
97+
getLabels(owner, name),
98+
isIssueEditable(repository),
99+
isIssueManageable(repository),
100+
repository)
101+
}
98102
} getOrElse NotFound()
99103
}
100104
})

0 commit comments

Comments
 (0)