Add check for ACR registry in ACR credential helper #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1658 +/- ##
===========================================
- Coverage 52.92% 42.18% -10.75%
===========================================
Files 44 121 +77
Lines 3979 7190 +3211
===========================================
+ Hits 2106 3033 +927
- Misses 1651 3802 +2151
- Partials 222 355 +133 ☔ View full report in Codecov by Sentry. |
malancas
approved these changes
Oct 9, 2024
|
The original issue seems to be resolved by #1656, which merged earlier today. I still think this PR is good to merge, as it will speed things along slightly if ACR is not used, but the fix has basically been implemented. |
hectorj2f
approved these changes
Oct 9, 2024
|
Thanks @codysoyland although there is one CI check failing. |
Signed-off-by: Cody Soyland <codysoyland@github.com>
codysoyland
force-pushed
the
fix-azure-credhelper-block
branch
from
9338cb1
to
a4d3b49
Compare
hectorj2f
approved these changes
Oct 31, 2024
senanz
pushed a commit
to senanz/policy-controller
that referenced
this pull request
Nov 3, 2024
Signed-off-by: Cody Soyland <codysoyland@github.com> Signed-off-by: Senan Zedan (EXT-Nokia) <senan.zedan.ext@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a check that will only run the ACR credential helper when the target registry is a subdomain of
azurecr.io.This is similar to an existing check used for GCR.
Fixes #1657
Release Note
Documentation