Skip to content

Optimise parallelism in compute cells operations by zipping first #7574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

jimmygchen
Copy link
Member

Issue Addressed

We're seeing slow KZG performance on fusaka-devnet-0 and looking for optimisations to improve performance.

Zipping the list first then into_par_iter shows a 10% improvement in performance benchmark, i suspect this might be even more material when running on a beacon node.

Before:

blobs_to_data_column_sidecars_20
                        time:   [11.583 ms 12.041 ms 12.534 ms]
Found 5 outliers among 100 measurements (5.00%)

After:

blobs_to_data_column_sidecars_20
                        time:   [10.506 ms 10.724 ms 10.982 ms]
                        change: [-14.925% -10.941% -6.5452%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)

@jimmygchen jimmygchen added optimization Something to make Lighthouse run more efficiently. das Data Availability Sampling labels Jun 6, 2025
@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Jun 6, 2025
Copy link
Member

@eserilev eserilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jun 9, 2025
mergify bot added a commit that referenced this pull request Jun 9, 2025
@mergify mergify bot merged commit 8c6abc0 into sigp:unstable Jun 9, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling optimization Something to make Lighthouse run more efficiently. ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants