Optimize validate_data_columns
#7326
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
added
work-in-progress
eserilev
changed the title
eserilev
changed the title
eserilev
changed the title
eserilev
changed the title
validate_data_columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on conversation here:
https://discord.com/channels/595666850260713488/1360117816228843570/1360291212464099539
We've seen metrics that show beacon block header, inclusion proof etc. scaling with blob count. This PR aims to make a small optimization to
validate_data_columns. Will need to test this to see if this makes any difference when scaling up blob count, though in general I think this is a safe optimization to include regardless.