Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lighthouse_network dependency from eth2 crate #6679

Closed
wants to merge 2 commits into from

Conversation

pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

The eth2 which contains our http api client crate depends on the lighthouse_network crate for some networking types.
This is completely unnecessary imo because we can just return strings/serde_json::Value types for the networking types.
These types don't require us using any of the functions on the type structs. They just exist for some typing.

This is an enormous source of pain for any dependency that pulls the eth2 crate for using a BeaconNodeHttpClient because importing lighthouse_network pulls in a bunch of other dependencies that just bloats the dep tree.

I don't see any reason why the networking related types cannot be represented as String or json values. Let me know if that is not the case.

Todo

  • Test all affected endpoints

@AgeManning
Copy link
Member

The same as this? #6452

@pawanjay176
Copy link
Member Author

Yeah there's already work being done on this. I'm closing this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants