Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct flakey CI tests #6646

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Correct flakey CI tests #6646

merged 3 commits into from
Dec 10, 2024

Conversation

AgeManning
Copy link
Member

Issue Addressed

Some subnet service tests were failing occasionally. There were two bugs that I found.

I've run these tests repeatedly without fail, so at the very least, should make these more stable.

@AgeManning AgeManning added the ready-for-review The code is ready for review label Dec 2, 2024
@michaelsproul
Copy link
Member

Clippy is failing

@ackintosh ackintosh mentioned this pull request Dec 2, 2024
Open
@michaelsproul
Copy link
Member

Does the test_subscribe_same_subnet_several_slots_apart test need the same fix as the same_slot test? It is still failing on this branch: https://github.com/sigp/lighthouse/actions/runs/12114467475/job/33771078350?pr=6646

@michaelsproul michaelsproul added test improvement Improve tests waiting-on-author The reviewer has suggested changes and awaits thier implementation. v6.1.0 New release c. Q1 2025 and removed ready-for-review The code is ready for review labels Dec 2, 2024
@michaelsproul michaelsproul mentioned this pull request Dec 2, 2024
Merged
@syjn99 syjn99 mentioned this pull request Dec 3, 2024
Merged
@michaelsproul michaelsproul mentioned this pull request Dec 10, 2024
Closed
jimmygchen
jimmygchen approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This should also fix the test @michaelsproul mentioned above.

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Dec 10, 2024
@michaelsproul michaelsproul changed the base branch from unstable to release-v6.0.1 December 10, 2024 03:14
@michaelsproul michaelsproul added v6.0.1 Bugfix for v6.0.0 and removed v6.1.0 New release c. Q1 2025 labels Dec 10, 2024
@michaelsproul
Copy link
Member

Rebased on release-v6.0.1 so we can merge there and then back-merge to unstable

@michaelsproul
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Dec 10, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 3b8254a

@mergify mergify bot merged commit 3b8254a into sigp:release-v6.0.1 Dec 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. test improvement Improve tests v6.0.1 Bugfix for v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AgeManning @michaelsproul @jimmygchen