Add minimal list validators #5334
Conversation
I wanted to be sure that my vc's were setup to properly for use with validator-manager using a "read-only" command, `list` seemed like an obvious choice.
|
I also added this command (among others) in the following PR #5347 - please let me know if I should remove it from there |
Updated SUMMARY.md, help_vm.md and scripts/cli.sh then ran `make cli-local` which created help_vm_list.md in the root. I then moved it to `book/src/`
Whatever the powerful say is fine with me, this a decision that is above my pay grade, LoL! |
Run `cargo fmt` to fix list_validators.rs format.
|
Thank you @winksaville for the contribution! This PR uses Given the existence of the keymanager API (see https://github.com/ethereum/keymanager-APIs) it is best to use its list endpoint. Speced here https://github.com/ethereum/keymanager-APIs/blob/a71e126e369a4ca762906f1d0884edcad70ee0ed/apis/local_keystores.yaml#L2) EDIT: @pahor167 's PR uses the keymanager API to list keystores, see https://github.com/sigp/lighthouse/pull/5347/files#diff-748ad38a4d2e54eeef556475f65a7d67a53fb644e416d87d7f0c68202fba1468R77 maybe we can focus on that one as it's closer to the end goal :) |
SGTM, if @Pahor is closer definitely use it. |
|
Closing in preference to #5347 |
Issue Addressed
There is no issue, I thought it was a nice to have.
Proposed Changes
Added list_validator.rs based on import_validators.rs, this command
lists all of the validators present on the target node.
Additional Info
Currently there are no tests,