Decouple gossip #3950
Closed
Decouple gossip #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
reviewed
Feb 16, 2023
| }; | ||
| crate::publish_pubsub_message(network_tx, PubsubMessage::BeaconBlock(block.clone()))?; | ||
|
|
||
| /* TODO: publish all blob sidecars associated with this block */ |
There was a problem hiding this comment.
there's an open discussion whether to do blob publishing separately
ethereum/beacon-APIs#300
PR: ethereum/beacon-APIs#302
divagant-martian
force-pushed
the
eip4844
branch
from
86e6906
to
55753f8
Compare
|
@pawanjay176 would it be helpful if we rebase this on the main blob branch and merge it? |
|
I think this will overlap with some of the caching stuff we are doing. But I can cherry pick the gossip validation changes in this PR and we can continue with the caching stuff in another PR. |
|
Relevant work extracted into #4092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
Start decoupling gossip logic according to ethereum/consensus-specs#3244