Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign and clean up store metrics #1307

Open
michaelsproul opened this issue Jun 29, 2020 · 2 comments
Open

Redesign and clean up store metrics #1307

michaelsproul opened this issue Jun 29, 2020 · 2 comments

Comments

@michaelsproul
Copy link
Member

Description

With the transition to atomic database operations, and the removal of various caches, several of the metrics in beacon_node/store/src/metrics.rs have become outdated. For example: DISK_DB_WRITE_BYTES is no longer complete, because it doesn't include writes from atomic transactions, and BEACON_STATE_CACHE_HIT_COUNT is unused since the LRU cache of beacon states was removed. There are a lot of store metrics in that file, and a bunch more are probably wrong/useless as well.

Completing this issue will probably happen naturally when someone next tries to optimise the store. A local grafana instance will be invaluable: https://github.com/sigp/lighthouse-metrics

@paulhauner
Copy link
Member

Did you already clear this up @michaelsproul? I vaguely recall something.

@michaelsproul
Copy link
Member Author

Not yet, it's still as it was when this issue was written

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants