Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand checked arithmetic to more crates #1013

Open
michaelsproul opened this issue Apr 17, 2020 · 1 comment
Open

Expand checked arithmetic to more crates #1013

michaelsproul opened this issue Apr 17, 2020 · 1 comment
Labels
A1 consensus An issue/PR that touches consensus code, such as state_processing or block verification.

Comments

@michaelsproul
Copy link
Member

Description

In #1009 we added lints for unchecked integer arithmetic and switched to checked arithmetic in the types and state_processing crates. This issue is about expanding that coverage to more crates, probably in eth2/utils to start with (i.e. the direct dependencies of state_processing).
@michaelsproul michaelsproul mentioned this issue Apr 17, 2020
Merged
@ghost ghost added A1 labels Sep 9, 2020
@paulhauner paulhauner added A1 and removed A1 labels Nov 8, 2020
@michaelsproul
Copy link
Member Author

Another one to remove, .abs() from fork choice

@michaelsproul michaelsproul added consensus An issue/PR that touches consensus code, such as state_processing or block verification. and removed t State Transition labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A1 consensus An issue/PR that touches consensus code, such as state_processing or block verification.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @paulhauner