From e3ce7fc5eae558da117b41ca7abbd6e03f4e420d Mon Sep 17 00:00:00 2001
From: dapplion <35266934+dapplion@users.noreply.github.com>
Date: Mon, 15 Jul 2024 17:36:05 +0200
Subject: [PATCH] Add BeaconBlocksByRange v3

---
 beacon_node/network/src/sync/block_lookups/mod.rs |  2 +-
 beacon_node/network/src/sync/range_sync/chain.rs  | 12 +++++++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/beacon_node/network/src/sync/block_lookups/mod.rs b/beacon_node/network/src/sync/block_lookups/mod.rs
index 0a44cf2fdf5..43bae1f9601 100644
--- a/beacon_node/network/src/sync/block_lookups/mod.rs
+++ b/beacon_node/network/src/sync/block_lookups/mod.rs
@@ -53,7 +53,7 @@ mod tests;
 /// The maximum depth we will search for a parent block. In principle we should have sync'd any
 /// canonical chain to its head once the peer connects. A chain should not appear where it's depth
 /// is further back than the most recent head slot.
-pub(crate) const PARENT_DEPTH_TOLERANCE: usize = SLOT_IMPORT_TOLERANCE * 2;
+pub(crate) const PARENT_DEPTH_TOLERANCE: usize = SLOT_IMPORT_TOLERANCE + 1;
 
 const FAILED_CHAINS_CACHE_EXPIRY_SECONDS: u64 = 60;
 pub const SINGLE_BLOCK_LOOKUP_MAX_ATTEMPTS: u8 = 4;
diff --git a/beacon_node/network/src/sync/range_sync/chain.rs b/beacon_node/network/src/sync/range_sync/chain.rs
index a735001fed3..0e4058dddf1 100644
--- a/beacon_node/network/src/sync/range_sync/chain.rs
+++ b/beacon_node/network/src/sync/range_sync/chain.rs
@@ -11,6 +11,7 @@ use rand::{seq::SliceRandom, Rng};
 use slog::{crit, debug, o, warn};
 use std::collections::{btree_map::Entry, BTreeMap, HashSet};
 use std::hash::{Hash, Hasher};
+use std::time::Instant;
 use types::{Epoch, EthSpec, Hash256, Slot};
 
 /// Blocks are downloaded in batches from peers. This constant specifies how many epochs worth of
@@ -109,6 +110,9 @@ pub struct SyncingChain<T: BeaconChainTypes> {
 pub enum ChainSyncingState {
     /// The chain is not being synced.
     Stopped,
+    /// The chain should not download any more batches, but should attempt to processing everything
+    /// that is already downloaded.
+    Stopping(Instant),
     /// The chain is undergoing syncing.
     Syncing,
 }
@@ -866,6 +870,11 @@ impl<T: BeaconChainTypes> SyncingChain<T> {
         network: &mut SyncNetworkContext<T>,
         batch_id: BatchId,
     ) -> ProcessingResult {
+        // If chain is stopping do not request any more batches.
+        if matches!(self.state, ChainSyncingState::Stopping) {
+            return Ok(KeepChain);
+        }
+
         let Some(batch) = self.batches.get_mut(&batch_id) else {
             return Ok(KeepChain);
         };
@@ -972,7 +981,7 @@ impl<T: BeaconChainTypes> SyncingChain<T> {
     pub fn is_syncing(&self) -> bool {
         match self.state {
             ChainSyncingState::Syncing => true,
-            ChainSyncingState::Stopped => false,
+            ChainSyncingState::Stopped | ChainSyncingState::Stopping { .. } => false,
         }
     }
 
@@ -991,6 +1000,7 @@ impl<T: BeaconChainTypes> SyncingChain<T> {
     /// Attempts to request the next required batches from the peer pool if the chain is syncing. It will exhaust the peer
     /// pool and left over batches until the batch buffer is reached or all peers are exhausted.
     fn request_batches(&mut self, network: &mut SyncNetworkContext<T>) -> ProcessingResult {
+        // If chain is stopped or stopping do not request any more batches.
         if !matches!(self.state, ChainSyncingState::Syncing) {
             return Ok(KeepChain);
         }