Skip to content

Commit 77caa97

Browse files
committed
Address some of Pawan's review comments
1 parent 63a39b7 commit 77caa97

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

beacon_node/beacon_chain/src/metrics.rs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1619,13 +1619,6 @@ pub static BLOBS_SIDECAR_PROCESSING_REQUESTS: LazyLock<Result<IntCounter>> = Laz
16191619
"Count of all blob sidecars submitted for processing",
16201620
)
16211621
});
1622-
pub static BLOBS_COLUMN_SIDECAR_PROCESSING_REQUESTS: LazyLock<Result<IntCounter>> =
1623-
LazyLock::new(|| {
1624-
try_create_int_counter(
1625-
"beacon_blobs_column_sidecar_processing_requests_total",
1626-
"Count of all data column sidecars submitted for processing",
1627-
)
1628-
});
16291622
pub static BLOBS_SIDECAR_PROCESSING_SUCCESSES: LazyLock<Result<IntCounter>> = LazyLock::new(|| {
16301623
try_create_int_counter(
16311624
"beacon_blobs_sidecar_processing_successes_total",

consensus/types/src/runtime_var_list.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ pub struct RuntimeVariableList<T> {
4646
}
4747

4848
impl<T> RuntimeVariableList<T> {
49-
/// Returns `Some` if the given `vec` equals the fixed length of `Self`. Otherwise returns
50-
/// `None`.
49+
/// Returns `Ok` if the given `vec` equals the fixed length of `Self`. Otherwise returns
50+
/// `Err(OutOfBounds { .. })`.
5151
pub fn new(vec: Vec<T>, max_len: usize) -> Result<Self, Error> {
5252
if vec.len() <= max_len {
5353
Ok(Self { vec, max_len })

0 commit comments

Comments
 (0)