Deprecate usage of bare env vars and config sources #5153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
deprecate-bare-style-expansion
branch
5 times, most recently
from
ce473ff
to
a979479
Compare
atoulme
approved these changes
Jul 29, 2024
jvoravong
approved these changes
Jul 29, 2024
Deprecate usage of bare environment variables and config sources in configuration files.
- Use `${env:VAR}` or `${VAR}` instead of `$VAR`.
- Use `${uri:selector}` instead of `${uri:selector}`, e.g. `${file:/path/to/file}` instead of `$file:/path/to/file`.
Detect such usages and print a deprecation warning. It's ok to not use logger because it's not initiated at this point yet. We use `log.Print` at the stage in other places as well.
dmitryax
force-pushed
the
deprecate-bare-style-expansion
branch
from
a979479
to
7470480
Compare
pjanotti
approved these changes
Jul 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate usage of bare environment variables and config sources in configuration files.
${env:VAR}or${VAR}instead of$VAR.${uri:selector}instead of$uri:selector, e.g.${file:/path/to/file}instead of$file:/path/to/file.Detect such usages and print a deprecation warning. It's ok to not use logger because it's not initiated at this point yet. We use
log.Printat this stage in other places as well.