Add bundled discovery configs to default config.d for rpm and deb packages #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Jun 26, 2023
theletterf
reviewed
Jun 26, 2023
| @@ -0,0 +1,18 @@ | |||
| # Copy this file to properties.discovery.yaml and add your uncommented discovery properties for use in discovery mode: | |||
| # For more information: | |||
| # https://github.com/signalfx/splunk-otel-collector/tree/main/internal/confmapprovider/discovery#discovery-properties | |||
There was a problem hiding this comment.
Ideally we'll want to link to the official docs after launch, although this one is technical enough to perhaps not require it.
There was a problem hiding this comment.
I can update the headers w/ prod links when the docs are released.
theletterf
approved these changes
Jun 26, 2023
jeffreyc-splunk
approved these changes
Jun 26, 2023
|
I will move this to ready once #3321 lands and I update the config.d header language based on feedback from Aunsh. |
rmfitzpatrick
force-pushed
the
debconfigd
branch
from
73ea707
to
6bf56c7
Compare
rmfitzpatrick
force-pushed
the
debconfigd
branch
from
6bf56c7
to
fe8e705
Compare
aunshc
reviewed
Jun 28, 2023
cmd/otelcol/config/collector/config.d.linux/extensions/docker-observer.discovery.yaml
Outdated
Show resolved
Hide resolved
aunshc
reviewed
Jun 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes include updated, commented-out discovery configs to the default
/etc/otel/collector/config.ddirectory for rpm and deb packages. They also include updates to the commented header and integration tests for basic discovery mode validation. These tests aren't going to be included in CI out of the gate, but that's my intention in the near future.cc @aunshc @theletterf