diff --git a/internal/confmapprovider/discovery/properties/conf_test.go b/internal/confmapprovider/discovery/properties/conf_test.go index 502f3fa0b6..0c8e5944d9 100644 --- a/internal/confmapprovider/discovery/properties/conf_test.go +++ b/internal/confmapprovider/discovery/properties/conf_test.go @@ -82,7 +82,7 @@ func TestInvalidConf(t *testing.T) { path: filepath.Join(".", "testdata", "invalid-mapping-unknown-component.yaml"), }, { - expectedError: "invalid property (parsing error): splunk.discovery:1:18: unexpected token \"123\" (expected (\"receivers\" | \"extensions\") ComponentID ((\"config\" ) | \"enabled\") ( | | )*); invalid property (parsing error): splunk.discovery:1:18: unexpected token \"processors\" (expected (\"receivers\" | \"extensions\") ComponentID ((\"config\" ) | \"enabled\") ( | | )*); invalid property (parsing error): splunk.discovery:1:57: unexpected token \"\" (expected ((\"config\" ) | \"enabled\") ( | | )*); invalid property (parsing error): splunk.discovery:1:87: unexpected token \"\" (expected ((\"config\" ) | \"enabled\") ( | | )*)", + expectedError: `invalid property "splunk.discovery.123" (parsing error): splunk.discovery:1:18: unexpected token "123" (expected ("receivers" | "extensions") ComponentID (("config" ) | "enabled") ( | | )*); invalid property "splunk.discovery.processors.a_processor.config.some_field" (parsing error): splunk.discovery:1:18: unexpected token "processors" (expected ("receivers" | "extensions") ComponentID (("config" ) | "enabled") ( | | )*); invalid property "splunk.discovery.receivers.a_receiver.unknown.some_field" (parsing error): splunk.discovery:1:57: unexpected token "" (expected (("config" ) | "enabled") ( | | )*); invalid property "splunk.discovery.receivers.another_receiver/with-name.another_unknown.some_other_field" (parsing error): splunk.discovery:1:87: unexpected token "" (expected (("config" ) | "enabled") ( | | )*)`, path: filepath.Join(".", "testdata", "invalid-set.yaml"), }, } { diff --git a/internal/confmapprovider/discovery/properties/property.go b/internal/confmapprovider/discovery/properties/property.go index 38c64af6ea..059655a6c7 100644 --- a/internal/confmapprovider/discovery/properties/property.go +++ b/internal/confmapprovider/discovery/properties/property.go @@ -74,7 +74,7 @@ type ComponentID struct { func NewProperty(property, val string) (*Property, error) { p, err := parser.ParseString("splunk.discovery", property) if err != nil { - return nil, fmt.Errorf("invalid property (parsing error): %w", err) + return nil, fmt.Errorf("invalid property %q (parsing error): %w", property, err) } p.Val = val diff --git a/internal/confmapprovider/discovery/properties/property_test.go b/internal/confmapprovider/discovery/properties/property_test.go index d0f10400fb..1352d31ec1 100644 --- a/internal/confmapprovider/discovery/properties/property_test.go +++ b/internal/confmapprovider/discovery/properties/property_test.go @@ -232,9 +232,9 @@ func TestInvalidProperties(t *testing.T) { for _, tt := range []struct { property, expectedError string }{ - {property: "splunk.discovery.invalid", expectedError: "invalid property (parsing error): splunk.discovery:1:18: unexpected token \"invalid\" (expected (\"receivers\" | \"extensions\") ComponentID ((\"config\" ) | \"enabled\") ( | | )*)"}, - {property: "splunk.discovery.extensions.config.one.two", expectedError: "invalid property (parsing error): splunk.discovery:1:43: unexpected token \"\" (expected ((\"config\" ) | \"enabled\") ( | | )*)"}, - {property: "splunk.discovery.receivers.type/name.config", expectedError: "invalid property (parsing error): splunk.discovery:1:44: unexpected token \"\" (expected )"}, + {property: "splunk.discovery.invalid", expectedError: "invalid property \"splunk.discovery.invalid\" (parsing error): splunk.discovery:1:18: unexpected token \"invalid\" (expected (\"receivers\" | \"extensions\") ComponentID ((\"config\" ) | \"enabled\") ( | | )*)"}, + {property: "splunk.discovery.extensions.config.one.two", expectedError: "invalid property \"splunk.discovery.extensions.config.one.two\" (parsing error): splunk.discovery:1:43: unexpected token \"\" (expected ((\"config\" ) | \"enabled\") ( | | )*)"}, + {property: "splunk.discovery.receivers.type/name.config", expectedError: "invalid property \"splunk.discovery.receivers.type/name.config\" (parsing error): splunk.discovery:1:44: unexpected token \"\" (expected )"}, } { t.Run(tt.property, func(t *testing.T) { p, err := NewProperty(tt.property, "val")