New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for session id name change #606

Closed

breedx-splk opened this issue Aug 10, 2023 · 1 comment

Assignees

Contributor

breedx-splk commented Aug 10, 2023 •

edited

Loading

It's likely that open-telemetry/semantic-conventions#215 will merge before too long, and we should prepare to handle data with the newer convention.

Recommend doing the following:

Rename rum.session.id to session.id. This allows us to use the new name internally everywhere
Leverage the SessionIdSpanAppender to copy the session.id back into the legacy rum.session.id name. We should then send both attributes. This allows us to remain backwards compatible while also allowing the backend to eventually begin using the new name.

The text was updated successfully, but these errors were encountered:

breedx-splk assigned surbhimaheshwari

surbhimaheshwari mentioned this issue

Added session.id as key along with rum.session.id for span #610

Closed

Contributor Author

breedx-splk commented Oct 17, 2023

We are using session.id from upstream RumConstants and turning it back into splunk.rumSessionId in the SplunkSpanDataModifier.

breedx-splk closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment