Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image preview clickable outside of preview boundary #5887

Open
2 tasks done
rrittenhouse opened this issue Apr 18, 2022 · 1 comment
Open
2 tasks done

Image preview clickable outside of preview boundary #5887

rrittenhouse opened this issue Apr 18, 2022 · 1 comment

Comments

@rrittenhouse
Copy link

  • I have searched open and closed issues for duplicates
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Bug Description

On signal desktop (5.39.0) I noticed that when you click to the left (or right depending on if it was sent or received) and there is no text with the image, it opens the image when it should not. if you include text with your image the image is not clickable outside of the bounds of where the image preview is.

Steps to Reproduce

  1. Send an image to somebody on Signal with Signal Desktop 5.39.0 with no text attached

Actual Result:

Image is clickable outside of the image preview bounds.

Expected Result:

I expect it not to open the image preview when I click on the background area to the left of the image. The same happens if somebody sends an image without text as well. If you send one with text along side the image, it works as expected.

Platform Info

Signal Version: 5.39.0

Operating System: Windows 10

Link to Debug Log

https://debuglogs.org/desktop/5.39.0/250755f5ca64797124c75898d89936124eda171392c54d3c89eaf9594d7ec53e.gz

@rrittenhouse rrittenhouse changed the title Images clickable when there's no text off of image Image preview clickable outside of preview boundary Apr 18, 2022
@kaktusztea
Copy link

It looks like this commit should fix the issue: 5e05343
(in v5.42.0-beta.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants