Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show sender's time; show the server's receive time #4927

Closed
chandradeepdey opened this issue Jan 21, 2021 · 7 comments
Closed

Don't show sender's time; show the server's receive time #4927

chandradeepdey opened this issue Jan 21, 2021 · 7 comments

Comments

@chandradeepdey
Copy link

chandradeepdey commented Jan 21, 2021

  • [ ✅] I have searched open and closed issues for duplicates

Bug Description

Title

Steps to Reproduce

  1. Change system time (mine was accidentally set to UTC because I hadn't configured dual boot properly yet)
  2. Send a message OR Receive a message

Actual Result:

For a sent message the message appears on all other devices and to the other participant as sent on Windows' system time instead of the correct time. This only happened with Windows, the Linux client worked fine.

For a received message the message appeared on both Signal desktops (Windows and Linux) as received at Windows' system time. The time was correct on Android (Android's system time was correct).

Expected Result:

The time should appear correct regardless of what the client sets the time to.

Platform Info

Signal Version:

1.39.6

Operating System:

Windows 10 19042.746
Arch Linux (rolling)

Linked Device Version:

Android 7.0

@chandradeepdey chandradeepdey changed the title Windows - don't let system time influence message sent time Windows - don't let system time influence message sent or received time of a message Jan 21, 2021
@chandradeepdey chandradeepdey changed the title Windows - don't let system time influence message sent or received time of a message Don't let system time influence message sent or received time of a message Jan 21, 2021
@scottnonnenberg-signal
Copy link
Contributor

Can you talk a little bit more about what you believe the 'correct' time should be? Right now we show you what the sender's device thought the time was when it sent it.

@chandradeepdey
Copy link
Author

Limit the effect of incorrect time of a device to that particular device

  • for received messages the times should be time the message reached the server (server time) and time it reached the current device (device time)
  • for sent messages the times should be time it was sent at (device time) and time it reached the first device (server time).

@scottnonnenberg-signal scottnonnenberg-signal changed the title Don't let system time influence message sent or received time of a message Don't show sender's time; show the server's receive time Jan 28, 2021
@pyrrhull
Copy link

Can confirm this issue. The message being sent from signal desktop on a windows pc with a wrong timezone setting.
The result is that in the chat the timeline doesn't make sense anymore.

@KommX
Copy link

KommX commented Feb 20, 2021

The red message in my screenshots below has the following timestamps:
image

Here's a screenshot from a group chat on Desktop:
image

The same chat on Android looks like this:
image

So, as @Makrobios mentioned the message order on Desktop appears to be wrong, but it's correct, because it's sorted by received date, but the sent date is used for the "relative timestamp".

Signal on Android doesn't rely on the sender's time.

@scottnonnenberg-signal Do you need more information? I'm asking because this issue still has the "Need Information" label.

@KommX
Copy link

KommX commented Apr 29, 2021

@scottnonnenberg-signal Do you need more information? I'm asking because this issue still has the "Need Information" label.

@stale
Copy link

stale bot commented Sep 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 23, 2021
@KommX
Copy link

KommX commented Sep 23, 2021

further activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants