Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save images as jpg and not as jpeg #4035

Closed
1 task done
PanderMusubi opened this issue Mar 9, 2020 · 7 comments
Closed
1 task done

Save images as jpg and not as jpeg #4035

PanderMusubi opened this issue Mar 9, 2020 · 7 comments

Comments

@PanderMusubi
Copy link

  • I have searched open and closed issues for duplicates

Bug Description

Save images as jpg and not as jpeg. All other software on desktop computer saves images as jpg so this needs extra manual changes in order to comply with what is expected on the desktop (for searching and managing images).

Steps to Reproduce

  1. Send a photograph to yourself or have someone send a photograph to you.
  2. Save that photograph from Signal Desktop to disk

Actual Result:

File name that is prompted / is suggested will have extension .jpeg

Expected Result:

File name that is prompted / is suggested will should have extension .jpg

Screenshots

2020-03-09-222747_1920x1080_scrot

Platform Info

Signal Version: 1.32.0-

Operating System: Ubuntu 19.10

Linked Device Version: Android 4.56.4

Link to Debug Log

n/a

See also https://community.signalusers.org/t/dont-use-jpeg-but-jpg-file-extension/12330

@scottnonnenberg-signal
Copy link
Contributor

Signal Desktop bases almost all of its attachment filename data on information that comes to it from the sending client. Which sending client is generating .jpeg filenames? How was that file originally generated, then added to Signal?

@PanderMusubi
Copy link
Author

If you send a .jpg and a .jpeg from the Android app, they both will be offered to be saved as .jpeg in the Desktop app, unfortuntely.

@UserX404
Copy link

UserX404 commented Aug 18, 2020

@scottnonnenberg-signal
I ran into this issue and testet on Android and Win10x64 with note-to-self. Same picture with alternated extensions. Afterwards i saved to disk.
Sent from Android -> Android: both saved as jpg, W10 both jpeg
Sent from W10 -> Android: both as jpg. W10: jpeg and jpg (same as original file)

  • It seems images always gets converted to jpg on Android and it doesn't matter if the original is jpeg, Jpeg or JPEG.
  • It seems Desktop uses original file extension when it comes from desktop client but from an other client is is always jpeg.
  • It seems Desktop doesn't convert lower case (JPG, JPEG, Jpg, Jpeg).

A consistent extension handling would be very welcome to get rid of duplicates unattached which client the image comes from.

grafik

Side note: The desktop's file size is bigger but i couldn't find a difference in quality.

@stale
Copy link

stale bot commented Sep 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@PanderMusubi
Copy link
Author

This is still an issue, please reopen.

@PanderMusubi
Copy link
Author

According to the forum, a fix is underway. Thanks.

@QuadrupleA
Copy link

I've also been having this problem. Currently experiencing it with the Motorola/Android camera app - share, then send to Signal - when downloading from Signal desktop the extension is always .jpeg which is awkward and less recognized.

Some code in signal desktop to just convert extensions to .jpg on save/download would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants