Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mastodon URLs are not clickable #3295

Closed
Brog33 opened this issue Apr 5, 2019 · 4 comments
Closed

Mastodon URLs are not clickable #3295

Brog33 opened this issue Apr 5, 2019 · 4 comments

Comments

@Brog33
Copy link

Brog33 commented Apr 5, 2019

Bug Description

URLs containing @ is not parsed at an URL.

Steps to Reproduce

  1. Paste in an url containing the letter '@', such as https://mastodon.social/@HackerNewsBot

Actual Result:

The link is not clickable.

Expected Result:

The link should be clickable.
(These links are clickable in the Android client).

Screenshots

linkbug

Platform Info

Signal Version: v1.23.2

Operating System: Ubuntu 18.10

Linked Device Version: 4.36.2

@scottnonnenberg-signal
Copy link
Contributor

Yep, due to the way the some browsers parse the @ sign in urls, we explicitly disabled linkification for any url with an @ in it.

@brad112358
Copy link

This is change is annoying as many useful URLs no longer work.
Which browsers have broken behavior on parsing "@" in a passed URL and what are they doing with it?

@Brog33
Copy link
Author

Brog33 commented Apr 26, 2019

Hmm. Would like to know as well. Isn’t this an issue that rather needs to be addressed in the affected browsers? And why are these URLs being parsed correctly in the Signal mobile client anyways. Is it only an issue with desktop browsers?

@scottnonnenberg-signal
Copy link
Contributor

We've done a little bit of research on this - feel free to add a feature request to allow @ signs in link path segments (but still don't linkify if they are in the link's domain).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants