Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors in Signal are completely wrong #3159

Closed
1 task done
garrett opened this issue Feb 19, 2019 · 3 comments
Closed
1 task done

Colors in Signal are completely wrong #3159

garrett opened this issue Feb 19, 2019 · 3 comments

Comments

@garrett
Copy link

garrett commented Feb 19, 2019

  • I have searched open and closed issues for duplicates

Bug Description

I've upgraded Signal to the latest version, and now colors are incorrect.

It looks like it's applying some weird incorrect color profile to the Signal window. Both of my monitors are calibrated, so I'm guessing it's something related to that. (Every single other app works as expected, and so did Signal before updating.)

My guess is that Electron was updated (recent commit) and it either has broken color profile support or Signal now needs to do something to handle color management (#3112).

Meanwhile, using Signal on the desktop is nearly impossible with the awful colors.

Steps to Reproduce

Upgrade Signal to 1.21.2 on a color-managed Linux workstation.

Actual Result:

Colors are incorrect.

Expected Result:

Colors should be displayed as before the upgrade, in a correct manner.

Screenshots

As I don't want to expose other's information, I'm attaching screenshots of the About Signal dialog and a picture someone sent to a group (as well as a download of how it should look).

Here's the about dialog. As you can see, the colors are incorrect.
signal-about

Screenshot of a photo someone took and sent to a group versus reference:

signal-mate signal-attachment-2019-02-14-200004-resized

In addition, I took a screenshot of the top-left of Signal, which includes the menubar (wrong color) and my avatar (which should look like the one here on GitHub... but no longer does due to the wrong colors):

signal-topleft

Platform Info

Signal Version:

1.21.2

Operating System:

  • Linux (Fedora 29)
  • Flatpak from Flathub (as there are still no official packages for Linux distributions besides Debian)
  • Wayland, color managed

(All of this worked perfectly fine before the recent update.)

Linked Device Version: 4.33.5

Link to Debug Log

https://debuglogs.org/104605a6e1bf94ffe8a075e2019321319da4544cc169b235ffb5273f465bf77a

@garrett
Copy link
Author

garrett commented Feb 19, 2019

As Flatpak supports downgrading, I tried all these versions:

  • 1.21.2
  • 1.21.1
  • 1.20.0
  • 1.19.0
  • 1.18.1
  • 1.18.0

...and I have the same issues. So I guess something changed aside from Signal.

I'm still pretty sure it's color management related.

@garrett
Copy link
Author

garrett commented Feb 19, 2019

I toggled color management off and on again and things work as expected.

However, I do have to say that this issue came up the past few days, with reboots in-between.

I suppose a proper fix would be to properly support color management.

@scottnonnenberg-signal
Copy link
Contributor

Yep, I'm going to close this in favor of #3112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants