Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The attachments should be encrypted at rest on the drive #2793

Closed
1 task done
tinman-chad opened this issue Oct 16, 2018 · 0 comments
Closed
1 task done

The attachments should be encrypted at rest on the drive #2793

tinman-chad opened this issue Oct 16, 2018 · 0 comments

Comments

@tinman-chad
Copy link

  • I have searched open and closed issues for duplicates

Bug description

The attachments should be encrypted at rest on the drive not just named something that isn't the original file name.

Because I was curious, I went looking. The attachments are stored on the file system not encrypted. This should be considered PII information and should therefore be encrypted at rest on the drive even when not in use. I would assume that this is also the same problem on the phone applications.

Steps to reproduce

  1. Send/Receive any attachment.
  2. Open AppData\Roaming\Signal\attachments.noindex and find attachements in sub directories.
  3. Click open with and guess the application (for me that was super easy open in hex editor to see the file type in the file)

Actual result:
View attachment that was sent through signal even if those are not your attachments but another users.

Expected result:
Files would be encrypted just the same as in the application thus do not render in any application outside of signal without selected to download the file to store it locally for that purpose.

Platform info

Signal Desktop for windows.
Signal version:
1.16.3

Operating System:
Windows 7, Windows 10

Linked device version:
Android 8.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants