Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obfuscate the attachement download links in debug log #1939

Closed
breznak opened this issue Jan 4, 2018 · 0 comments
Closed

Obfuscate the attachement download links in debug log #1939

breznak opened this issue Jan 4, 2018 · 0 comments

Comments

@breznak
Copy link

breznak commented Jan 4, 2018

As discussed here #1442 (comment)
The log contains links for attachment download which look like:
https://whispersystems-textsecure-attachments.s3-accelerate.amazonaws.com/3399142333737380479?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20180103T223203Z&X-Amz-SignedHeaders=content-type;host&X-Amz-Expires=3600&X-Amz-Credential=AKIAJHWS3AOTJTASHBDA/20180103/us-east-1/s3/aws4_request&X-Amz-Signature=e1e8f3ac9782447d120430b2747fbe4cf067262a33302ae9cc60ee02a6e29b97

Regarding the attachments, the links expire over time, and the actual file contents are encrypted. But you're right, we could probably obscure some of those querystring arguments to make it even harder to get access to those attachments.

Suggested redaction:
https://whispersystems-textsecure-attachments.s3-accelerate.amazonaws.com/3399142333737380479?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20180103T223203Z&X-Amz-SignedHeaders=content-type;host&X-Amz-Expires=3600&X-Amz-Credential=REDACTED/20180103/us-east-1/s3/aws4_request&X-Amz-Signature=REDACTED9b97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants