Fixed a crash in the mac part of hidapi. #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issue signal11#26 Additionally added some error output for the return code of IOHIDManagerOpen()
|
I can see how this will make it not crash, but a failure of IOHidManagerOpen() is a fairly serious thing. Based on your comments in #26, I'm a bit unclear on whether you think this will actually make anything work (rather than just fail gracefully)? |
|
+1 for failing gracefully |
erikolofsson
pushed a commit
to Malterlib/hidapi
that referenced
this pull request
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hidapi crashes with SIGSEGV/SIGBUS when
IOHIDManagerOpen()doesn't returnkIOReturnSuccessAlso see issue #26
Additionally added some error output for the return code of
IOHIDManagerOpen()