Fix match API to allow pattern or string #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current API expects a
Patterntype, but the internal code expects astr(hence it callsre.compile). It turns out callingre.compileon aPatternworks. The documentation shows passing in astr, which seems like a convenient API. Adding the logic to supportPattern | strallows thematchAPI to work properly with thestrinterface while maintaining backwards compatibility with any existing code that passes an explicitly compiledPattern