feature: middleware to fix /auth/login/ page

[mavriq]

feature: added middleware to fix /auth/login/ for adding link to login via OIDC to organisations

[max-wittig]

@mavriq Sorry I missed this MR! Will look at it now

[mavriq]

Hi, @max-wittig
I hope, you looked my PR
And its doesn't look very strange

I used BeautifulSoup and MIDDLEWARE because we have no simple method to extend login page in sentry

[max-wittig]

@mavriq Mhmm I'm not really sure what it does. Could you provide some sort of screenshot or so?

[mavriq]

just now I can't make screeenshot, but I can tell you how it work:

1. here sentry/conf/server.py sentry set path to ROOT_URLCONF
2. here sentry/conf/urls.py it extends urlpatterns from sentry.web.urls.urlpatterns
3. here sentry/web/urls.py it adds sentry.web.frontend.auth_login.AuthLoginView as handler of ^auth/login/ named as sentry-login
4. after all this we have chain of calls:

• AuthLoginView.get -> AuthLoginView.handle_basic_auth
• AuthLoginView.handle_basic_auth -> AuthLoginView.respond_login
• AuthLoginView.respond_login call render sentry/login.html

5. see all next steps in sentry/templates/sentry/login.html
6. in middleware we:

• looking that this is login page and user is not authenticated
• find div class="tab-content" and his subtag div class="auth-container"
  if we can't find it - return
• because of we can not normally extend or replace block with div class="auth-provider-column", we
  • find or create div class="auth-provider-column"
  • create a queryset with a list of organizations using oidc
  • and add them all in this block with correct format

later I try to create screenshot

[mavriq]

@max-wittig, as you asked, screenshot of <sentry-host>/auth/login/:

[mavriq]

Hi, @max-wittig, have you some news about this PR?
I would really like this functionality to be in upstream, and I could use the package from pypi, and not manually patched

I didn't find an easier way.
this one works reliably.

[max-wittig]

@mavriq I'm not sure, this seems a bit patched. Normally we use the button on the right of your screenshot Single Sign-On. Have you tested it with multiple organizations? What happens then? Which one does it login with?

[max-wittig]

we have like 50 organizations in one instance. That would really mess up the page.

[mavriq]

hmm
yes, it must look crazy
can we add regex-variable to filter by slug-field? with default value .*

[mavriq]

In the 970f1e2 I did it

[mavriq]

@max-wittig maybe, you want add scrolbar, or move list of organizations to select/select2 ?
I can do it, but it will be ugly

[max-wittig]

@mavriq I'm not sure why we should follow this direction at all to be honest. Why can't the user just type in the org on the right?

[dlouzan]

@max-wittig I guess we can close this one as it's not the direction we want to go?

[max-wittig]

@mavriq Thanks for your contribution here, but sadly this doesn't follow our direction for this project.

Maybe, if you really want it you could make it optional?