-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blocklist and allowlist for oidc domains #28
base: master
Are you sure you want to change the base?
Conversation
@max-wittig @ercanucan I have tried as much as possible to keep with your philosophy of keeping the codebase as close as possible to upstream. |
Sorry I totally missed your MR. Didn't get any notifications for it. Will take a look in the next few days! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the MR. Just some suggestions added
Regarding your commit messages. Could you please ensure that these comply with the conventional changelog? Thanks 👍 |
Thanks @max-wittig I'll address these immediately. |
@max-wittig Would we want to take another look at this now that builds are fixed again? /cc @nejch |
`hd` is a Google Specific claim and is not present in other OIDC providers.
d2d1b54
to
2113e01
Compare
This introduces 2 variables
OIDC_DOMAIN_BLOCKLIST
OIDC_DOMAIN_ALLOWLIST
to filter out which email domains are allowed to login when using SSO.
Related issue
#27
It is possible to do away entirely with these new variables if equivalent setting for
domains
can be found. However, this seems not to be available.getsentry/self-hosted#2894