-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APNs Token Authentication #42
Comments
@vivangkumar I have been working on this. |
That's great news. Sure, I'll pop back once the branch is up and have a look :) Thanks! |
Hey @vivangkumar |
I use "github.com/dgrijalva/jwt-go" to generate jwt-token. Here is an example https://github.com/laozi2/token-auth-apns-http2-proxy |
For a list of various JWT libraries, see https://jwt.io/ and click Libraries and Filter By "Go". |
Thanks guys. I ended up using jwt-go. Here is my [WIP] PR #43 |
@sideshow any updates on this feature? |
@raphaeljlps The PR is here #43 however we are still blocked by the way the golang http2 implementation interprets the The two options to move this issue forward are;
None of these are amazing, but open to suggestions to move it forward. |
@sideshow A third option might be just to hack it? Assume 1 request at a time until the first one succeeds, then bring up a worker pool. One thing I'm not sure about though is if the connection is lost, in which case it may need to drop back down to 1 request at a time on a new connection. |
@nathany Good idea - could be the best solution for now. Agree it's a bit hacky but would allow us to move forward! |
We're also eagerly looking forward to this functionality. :) In the meantime, is there a known workaround that allows to use apns2 with Token Authentication already? |
@markschmid The library that you linked to suffers from the same issue when used asyncronously, I was able to reproduce the error ( Here is his sample code with lines 101-115 modified to use async behaviour and reproduce the problem https://gist.github.com/sideshow/b4d8898e76813216d1fc2b8ad12e4eef#file-test-go-L105-L115 If you haven't encountered this bug then you may not be using his library in an async manner and in that case you would be better to the apps/2 |
Haven't been aware of the feature-auth-token branch. Great stuff, thanks. |
Done :) |
Hello there!
Are there plans to add the newly released Token Authentication to the library? If there is work already in progress, when can we expect it to be merged into master and if not, will a PR be welcome?
The text was updated successfully, but these errors were encountered: